Refactor the kwargs_to_strings decorator to avoid try-except in loops #2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Thanks @seisman, I was just looking at modifying this chunk of code for #2884 (comment)! Will let you merge this in first before I add the extra logic for timedelta64 support.
Comment on lines
+762
to
-768
| if " " in str(item): | ||
| # Check if there is a space " " when converting | ||
| # a pandas.Timestamp/xr.DataArray to a string. | ||
| # If so, use np.datetime_as_string instead. | ||
| assert " " not in str(item) | ||
| except AssertionError: |
There was a problem hiding this comment.
Yeah, looking back at #562 (comment), not sure why I went with try-except instead of just an if-then check 😅
weiji14
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version