-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.text: Support passing in a list of angle/font/justify values #2720
Merged
+57
−22
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c7cb217
Figure.text: Support passing in a list of angle/font/justify values
seisman 17fb9db
Simplify the handling of angle/font/justify
seisman 3b2ebfa
Improve the docstrings
seisman 9e8e9c8
Add a test for passing a justify array
seisman 538780a
Fix the bug when concatenating strings arrays with spaces
seisman 2359c04
Add one more test
seisman 3fa58be
Revert "Fix the bug when concatenating strings arrays with spaces"
seisman bc89cb9
Fix linting issue
seisman 54df984
Update pygmt/src/text.py
seisman df38344
Merge branch 'main' into text-list-support
seisman 610f765
Merge branch 'main' into text-list-support
seisman c39f196
Merge branch 'main' into text-list-support
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
pygmt/tests/baseline/test_text_angle_justify_font_arrays.png.dvc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
outs: | ||
- md5: c111539b0b5966eee4305f9485c85bd0 | ||
size: 8208 | ||
hash: md5 | ||
path: test_text_angle_justify_font_arrays.png |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines were initially added in #321, but they should NOT be like this.