Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPython to GMT Legacy Tests CI environment #2283

Merged
merged 16 commits into from
Dec 31, 2022
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:

# Run full tests including doctests on Wednesday
- name: Run full tests
if: github.event_name == 'schedule' && github.event.schedule == '0 0 * * 3'
if: github.event_name == 'schedule' && endswith(github.event.schedule, '3')
weiji14 marked this conversation as resolved.
Show resolved Hide resolved
run: make fulltest PYTEST_EXTRA="-r P"

# Upload diff images on test failure
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/ci_tests_legacy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: GMT Legacy Tests
on:
# push:
# branches: [ main ]
# pull_request:
pull_request:
# types: [ready_for_review]
# paths-ignore:
# - 'doc/**'
Expand Down Expand Up @@ -65,7 +65,8 @@ jobs:
- name: Install dependencies
run: |
mamba install gmt=${{ matrix.gmt_version }} numpy \
pandas xarray netCDF4 packaging geopandas \
pandas xarray netCDF4 packaging \
geopandas ipython \
build dvc make 'pytest>=6.0' \
pytest-cov pytest-doctestplus pytest-mpl sphinx-gallery

Expand Down
1 change: 1 addition & 0 deletions pygmt/src/coast.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def coast(self, **kwargs):
... )
>>> # Show the plot
>>> fig.show()
<IPython.core.display.Image object>
"""
kwargs = self._preprocess(**kwargs) # pylint: disable=protected-access
if not args_in_kwargs(args=["C", "G", "S", "I", "N", "E", "Q", "W"], kwargs=kwargs):
Expand Down
1 change: 1 addition & 0 deletions pygmt/src/grd2cpt.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ def grd2cpt(grid, **kwargs):
>>> fig.grdimage(grid=grid)
>>> # show the plot
>>> fig.show()
<IPython.core.display.Image object>
"""
if kwargs.get("W") is not None and kwargs.get("Ww") is not None:
raise GMTInvalidInput("Set only categorical or cyclic to True, not both.")
Expand Down
1 change: 1 addition & 0 deletions pygmt/src/grdcontour.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def grdcontour(self, grid, **kwargs):
... )
>>> # show the plot
>>> fig.show()
<IPython.core.display.Image object>
"""
kwargs = self._preprocess(**kwargs) # pylint: disable=protected-access
with Session() as lib:
Expand Down
1 change: 1 addition & 0 deletions pygmt/src/grdimage.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def grdimage(self, grid, **kwargs):
>>> fig.grdimage(grid=grid, cmap="geo", projection="W10c", frame="ag")
>>> # show the plot
>>> fig.show()
<IPython.core.display.Image object>
"""
kwargs = self._preprocess(**kwargs) # pylint: disable=protected-access
with Session() as lib:
Expand Down
1 change: 1 addition & 0 deletions pygmt/src/solar.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ def solar(self, terminator="d", terminator_datetime=None, **kwargs):
... )
>>> # show the plot
>>> fig.show()
<IPython.core.display.Image object>
"""

kwargs = self._preprocess(**kwargs) # pylint: disable=protected-access
Expand Down