Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused global variable 'gmt_version' from tests #1552

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 29, 2021

Description of proposed changes

The variable gmt_version was used when we need to write tests that fail or pass with specific GMT versions. Now the variable is no longer needed and can be removed.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 29, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 29, 2021
@seisman seisman changed the title Remove unused global variable from tests Remove unused global variable 'gmt_version' from tests Sep 29, 2021
@seisman seisman merged commit c23a7d6 into main Sep 30, 2021
@seisman seisman deleted the remove-unused-var branch September 30, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants