-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygmt.surface: Deprecate parameter "outfile" to "outgrid" (remove in v0.7.0) #1458
pygmt.surface: Deprecate parameter "outfile" to "outgrid" (remove in v0.7.0) #1458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I have made one suggestion for adding a test.
Ping @obaney. |
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Merged in @meghanrjones 's helpful test suggestion, it appears that I am failing some checks however |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @obaney! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…v0.7.0) (GenericMappingTools#1458) * Rename outfile to outgrid in surface * Switch outfile to outgrid in test file * Update pygmt/tests/test_surface.py Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Description of proposed changes
Fixes #1441
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version