Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the getbyattrib function to select more elements. Make filter and findall aliases of it. #1239

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

joa-quim
Copy link
Member

Make filter() and findall() aliases of getbyattrib .

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #1239 (5b05e38) into master (c3d7994) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   91.48%   91.53%   +0.04%     
==========================================
  Files         127      127              
  Lines       15330    15341      +11     
==========================================
+ Hits        14025    14042      +17     
+ Misses       1305     1299       -6     
Files Changed Coverage Δ
src/show_pretty_datasets.jl 62.50% <ø> (+2.50%) ⬆️
src/utils_types.jl 88.23% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

@joa-quim joa-quim merged commit f7d5eae into master Aug 29, 2023
6 of 7 checks passed
@joa-quim joa-quim deleted the filter-findall-attribs branch August 29, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants