Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added host and docstrings to resources module #13

Merged
merged 5 commits into from
Jul 17, 2024
Merged

added host and docstrings to resources module #13

merged 5 commits into from
Jul 17, 2024

Conversation

avantikalal
Copy link
Collaborator

@avantikalal avantikalal commented Jul 10, 2024

  • Added host as an optional argument to all model zoo related functions in grelu.resources so that users can choose which model zoo to load models from.
  • Added documentation to all grelu.resources functions.

Addresses #16

@avantikalal avantikalal requested a review from suragnair July 16, 2024 18:05
@gokceneraslan
Copy link
Collaborator

LGTM. One small fix we can fold into this is to add anonymous="allow" to wandb.login by default, which gave us some trouble in the colab notebook. I think the default is anonymous='never', so wandb forces the users to login. With anonymous='allow' it checks if the user is already logged in, and if not it creates an anonymous credential and moves on.

@avantikalal avantikalal merged commit b7336fa into main Jul 17, 2024
1 check passed
@avantikalal avantikalal deleted the add_host branch July 17, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants