feat(components): bring back the custom-elements-manifest analyzer #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKellerer
approved these changes
Apr 3, 2024
fengelniederhammer
force-pushed
the
34-use-custom-elements-manifest-to-document-components
branch
from
8cbe951
to
f43ff13
Compare
fengelniederhammer
deleted the
34-use-custom-elements-manifest-to-document-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #34
Summary
I think IntelliJ has no proper support for the manifest, but the generated manifest looks ok (as far as I can judge). It isn't used anywhere, but it should probably be contained in the published package (once we publish).
Screenshot
PR Checklist
[ ] The implemented feature is covered by an appropriate test.