Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework error handling #366

Closed
fengelniederhammer opened this issue Jul 22, 2024 · 1 comment · Fixed by #431 or #442
Closed

Rework error handling #366

fengelniederhammer opened this issue Jul 22, 2024 · 1 comment · Fixed by #431 or #442
Assignees
@fengelniederhammer
Labels
components Regarding the components

Comments

@fengelniederhammer
Copy link
Collaborator

fengelniederhammer commented Jul 22, 2024 •
edited
Loading

#143 added an error boundary to our components. Most of the errors will however just be displayed as "Whoops, something went wrong".

We should give the user more indication on what went wrong in the expected cases, i.e. throw more UserFacingErrors.
@fengelniederhammer fengelniederhammer added the components Regarding the components label Jul 22, 2024
@chaoran-chen
Copy link
Member

Also, throwing an event would be useful so that the maintainer can catch and handle the error on a higher level if desired.

@fengelniederhammer fengelniederhammer self-assigned this Aug 2, 2024
fengelniederhammer added a commit that referenced this issue Aug 2, 2024
@fengelniederhammer
feat(components): dispatch gs-error event when an error occurs
9b9f0c2 
closes #366
fengelniederhammer added a commit that referenced this issue Aug 2, 2024
@fengelniederhammer
feat(components): also display error details when LAPIS calls fail
56bd18f 
closes #366
fengelniederhammer added a commit that referenced this issue Aug 2, 2024
@fengelniederhammer
feat(components): also display error details when LAPIS calls fail
9c54a31 
closes #366
@fengelniederhammer fengelniederhammer mentioned this issue Aug 2, 2024
Merged
2 tasks
fengelniederhammer added a commit that referenced this issue Aug 20, 2024
@fengelniederhammer
feat(components): dispatch gs-error event when an error occurs
062caaa 
closes #366
fengelniederhammer added a commit that referenced this issue Aug 20, 2024
@fengelniederhammer
feat(components): also display error details when LAPIS calls fail
49e6f24 
closes #366
fengelniederhammer added a commit that referenced this issue Aug 20, 2024
@fengelniederhammer
feat(components): dispatch gs-error event when an error occurs
1483a10 
closes #366
fengelniederhammer added a commit that referenced this issue Aug 20, 2024
@fengelniederhammer
feat(components): also display error details when LAPIS calls fail
a480b65 
closes #366
JonasKellerer pushed a commit that referenced this issue Aug 21, 2024
@fengelniederhammer @JonasKellerer
feat(components): also display error details when LAPIS calls fail
fbb16a4 
closes #366
This was referenced Aug 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
components Regarding the components
Projects
None yet
Milestone
No milestone
2 participants
@chaoran-chen @fengelniederhammer