Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date range filter: custom initial value #245

Closed
Tracked by #268
chaoran-chen opened this issue May 19, 2024 · 2 comments · Fixed by #256
Closed
Tracked by #268

Date range filter: custom initial value #245

chaoran-chen opened this issue May 19, 2024 · 2 comments · Fixed by #256
Assignees
@fengelniederhammer
Labels
components Regarding the components

Comments

@chaoran-chen
Copy link
Member

It should be possible to set any arbitrary date range as the initial value. (I think that's not possible at the moment?)
@chaoran-chen chaoran-chen added the components Regarding the components label May 19, 2024
@JonasKellerer
Copy link
Collaborator

It is currently not possible, only selecting from the predefined list.

@chaoran-chen chaoran-chen mentioned this issue May 20, 2024
Closed
@fengelniederhammer fengelniederhammer self-assigned this May 21, 2024
fengelniederhammer added a commit that referenced this issue May 21, 2024
@fengelniederhammer
fix(components): gs-date-range-selector: set initial dateFrom and…
524b427 
… `dateTo` values from `initialValue` #245
@fengelniederhammer fengelniederhammer mentioned this issue May 21, 2024
Merged
1 task
@fengelniederhammer
Copy link
Collaborator

As discussed:

The component should have two attributes initialFrom and initialTo. If any of them is set, it overwrites the initialValue to use custom. Of exactly one of them is set, take a default for the other (earliest date / today).

fengelniederhammer added a commit that referenced this issue May 23, 2024
@fengelniederhammer
fix(components): gs-date-range-selector: set initial dateFrom and…
00a7830 
… `dateTo` values from `initialValue` #245

Bug: It always took the values for `last6Months`
fengelniederhammer added a commit that referenced this issue May 23, 2024
@fengelniederhammer
feat(components): gs-date-range-selector: add attributes `initialDate…
c5a0eef 
…From`, `initialDateTo` #245

They overwrite the `initialValue` and directly set a custom date range.
fengelniederhammer added a commit that referenced this issue May 23, 2024
@fengelniederhammer
feat(components): gs-date-range-selector: add attributes `initialDate…
12b8302 
…From`, `initialDateTo` #245

They overwrite the `initialValue` and directly set a custom date range.
@chaoran-chen chaoran-chen mentioned this issue May 23, 2024
Open
3 tasks
fengelniederhammer added a commit that referenced this issue May 28, 2024
@fengelniederhammer
fixup! feat(components): gs-date-range-selector: add attributes `init…
5528222 
…ialDateFrom`, `initialDateTo` #245
fengelniederhammer added a commit that referenced this issue May 28, 2024
@fengelniederhammer
fix(components): gs-date-range-selector: set initial dateFrom and…
431fcc7 
… `dateTo` values from `initialValue` #245

Bug: It always took the values for `last6Months`
fengelniederhammer added a commit that referenced this issue May 28, 2024
@fengelniederhammer
feat(components): gs-date-range-selector: add attributes `initialDate…
759e58a 
…From`, `initialDateTo` #245

They overwrite the `initialValue` and directly set a custom date range.
fengelniederhammer added a commit that referenced this issue May 28, 2024
@fengelniederhammer
fix(components): gs-date-range-selector: set initial dateFrom and…
1c060f7 
… `dateTo` values from `initialValue` #245

Bug: It always took the values for `last6Months`
fengelniederhammer added a commit that referenced this issue May 28, 2024
@fengelniederhammer
feat(components): gs-date-range-selector: add attributes `initialDate…
c944011 
…From`, `initialDateTo` #245

They overwrite the `initialValue` and directly set a custom date range.
@github-actions github-actions bot mentioned this issue May 28, 2024
Merged
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
components Regarding the components
Projects
None yet
Milestone
No milestone
3 participants
@chaoran-chen @fengelniederhammer @JonasKellerer