Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return emptiness instead of null in TSV/CSVs #708

Closed
chaoran-chen opened this issue Mar 21, 2024 · 0 comments · Fixed by #724
Closed

Return emptiness instead of null in TSV/CSVs #708

chaoran-chen opened this issue Mar 21, 2024 · 0 comments · Fixed by #724
Assignees
@fengelniederhammer
Labels
bug Something isn't working

Comments

@chaoran-chen
Copy link
Member

@corneliusroemer found that in TSV files, the string null is provided if a value is null. That's only right for JSON (where we really have a null value) but in CSVs and TSVs, if a value is unknown, the field should simply be left empty.
@chaoran-chen chaoran-chen added the bug Something isn't working label Mar 21, 2024
@chaoran-chen chaoran-chen mentioned this issue Mar 21, 2024
Closed
3 tasks
@fengelniederhammer fengelniederhammer self-assigned this Apr 2, 2024
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
1d0beb4
@fengelniederhammer fengelniederhammer mentioned this issue Apr 2, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
83dd50d
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
fb16e2e
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
f161684
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
c15c323
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
bd37ddd
fengelniederhammer added a commit that referenced this issue Apr 2, 2024
@fengelniederhammer
fix: write empty string to CSV/TSV for null values #708
c8872ba
This was referenced May 6, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: write empty string to CSV/TSV for null values GenSpectrum/LAPIS
2 participants
@chaoran-chen @fengelniederhammer