Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent VARCHAR round-trip auto cast, check for duplicate primary keys and add preprocessing tests #624

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Prevent VARCHAR round-trip auto cast, check for duplicate primary keys and add preprocessing tests #624

merged 4 commits into from
Oct 25, 2024

Commits on Oct 24, 2024

  1. test: remove no-longer-used rsv dataset

    @Taepper @fengelniederhammer
    Taepper authored and fengelniederhammer committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    289992b View commit details
    Browse the repository at this point in the history

  2. fix(preprocessing): error on duplicate primary keys

    @Taepper @fengelniederhammer
    Taepper authored and fengelniederhammer committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d28cae7 View commit details
    Browse the repository at this point in the history

  3. fix: validate the column types earlier to prevent duckdb auto-casting… 

    … to cast types with differing round-trip conversions

We had a problem where DuckDB would wrongly autodetect types in the NDJSON input.
Types were inferred to "json" where they should have been strings.
    @Taepper @fengelniederhammer
    Taepper authored and fengelniederhammer committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    092e601 View commit details
    Browse the repository at this point in the history

  4. test: add test that checks that no round-trip VARCHAR casting is perf… 

    …ormed
    @Taepper @fengelniederhammer
    Taepper authored and fengelniederhammer committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    60958b1 View commit details
    Browse the repository at this point in the history