build: put conan-generated Find<lib>.cmake files in a separate directory from build/ #621
Conversation
|
There is no change in the changelog. This PR will not produce a new releasable version. |
Taepper
force-pushed
the
build-folder-split
branch
from
1dc775b
to
e7d57d0
Compare
Dockerfile_dependencies
Outdated
| @@ -16,4 +16,4 @@ RUN if [ "$TARGETPLATFORM" = "linux/arm64" ]; then \ | |||
| mv conanprofile.docker conanprofile; \ | |||
| fi | |||
|
|
|||
| RUN conan install . --build=missing --profile ./conanprofile --profile:build ./conanprofile --output-folder=build | |||
| RUN conan install . --build=missing --profile ./conanprofile --profile:build ./conanprofile --output-folder=cmake | |||
There was a problem hiding this comment.
(Not necessarily for this PR): I wonder why we don't simply use the build_with_conan script here? Actually there is no need to replicate this command in several places. And installing Python in the build stage of the Dockerfile would be no big deal.
| @@ -18,7 +18,8 @@ if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin") | |||
| endif () | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 20) | |||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/build/") | |||
|
|
|||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_BINARY_DIR}/generators/") | |||
There was a problem hiding this comment.
Out of interest: Is there a reason to use CMAKE_BINARY_DIR instead of CMAKE_SOURCE_DIR?
There was a problem hiding this comment.
First, we save the /build/ that was necessary before. (${CMAKE_SOURCE_DIR}/build/ was always equivalent to ${CMAKE_BINARY_DIR}/build)
But more importantly, CMAKE_BINARY_DIR is now a lot less magical in the discovery of the dependency files. For example before, CLion used cmake-build-debug/ as the build folder. Still, build/ was used to find the dependencies. Now, CMAKE_BINARY_DIR will already point at cmake-build-debug/ and looking for dependencies is relative to this directory
…ory in build/ and split up into Debug and Release Now the generated cmake files are put in build/Debug/generators/ and build/Release/generators/ respectively
Taepper
force-pushed
the
build-folder-split
branch
from
873ae36
to
62deb14
Compare
Summary
This follows the convention of putting helper .cmake files in to a separate directory as in: https://cmake.org/cmake/help/latest/variable/CMAKE_MODULE_PATH.html.
This additionally helps with developer setupt. There is now a separate folder (build/) to deleting all generated of the build system (cmake), and a folder (cmake/) of configuration files generated by the package manager (conan)
PR Checklist