Pull request linting #618
Merged
Pull request linting #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change in the changelog. This PR will not produce a new releasable version. |
Taepper
force-pushed
the
606-pull-request-linting
branch
from
ced2dc0
to
53ff9c5
Compare
…b api call resolves #606
Taepper
force-pushed
the
606-pull-request-linting
branch
from
471c236
to
7b65015
Compare
fengelniederhammer
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #606
Summary
The github api for pull-requests is specified here:
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests-files
I now specify the
per_pagevariable which is used for pagination to return 100 files (which is unfortunately the maximum) The default value is 30. This means that before no more than 30 files were returned by the endpoint in the CI actionAdditionally, I request the next page until we receive no more data, thus guaranteeing that we receive a complete file list, even when there are more than 100 files changed / added / moved / removed in the PR.
PR Checklist