feat: throw an error when there is not initialized database loaded yet #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
force-pushed
the
295-throw-an-error-when-there-is-no-database-loaded-yet
branch
from
37ff48f
to
ccff1c2
Compare
fengelniederhammer
force-pushed
the
295-throw-an-error-when-there-is-no-database-loaded-yet
branch
from
ccff1c2
to
19a8c40
Compare
Taepper
reviewed
Feb 26, 2024
| return; | ||
| } | ||
| } catch (const silo_api::UninitializedDatabaseException& exception) { | ||
| SPDLOG_DEBUG("No database loaded yet - continuing to load initial database."); |
There was a problem hiding this comment.
"continuing to load ..." can be confusing for users, if the database is currently not loading an existing database state
There was a problem hiding this comment.
(i.e. the maintainer / user thinks it is currently loading but in fact it still waits for data, maybe because of incorrect setup)
| response.setStatusAndReason(Poco::Net::HTTPResponse::HTTP_SERVICE_UNAVAILABLE); | ||
| std::string message = "Database not initialized yet."; | ||
|
|
||
| const auto retry_after = computeRetryAfter(); |
There was a problem hiding this comment.
Can we name the method computeRetryAfter better to something that makes it clear that it refers to 1. only the uninitialized error (other errors could in theory also have a retry) and 2. it is only a hint for the user?
Taepper
approved these changes
Feb 26, 2024
fengelniederhammer
deleted the
295-throw-an-error-when-there-is-no-database-loaded-yet
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #295
When SILO is still in it's configurable startup time, it will return: