Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Data error for very long sequences #266

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Jan 29, 2024

No description provided.

@Taepper Taepper requested review from fengelniederhammer and JonasKellerer and removed request for fengelniederhammer January 29, 2024 11:03
@Taepper Taepper force-pushed the data-error-very-long-sequences branch from 4442736 to 2eca946 Compare January 29, 2024 11:49
@Taepper Taepper force-pushed the data-error-very-long-sequences branch from 2eca946 to b29ebb1 Compare January 29, 2024 11:50
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FROM '{}'
WHERE metadata.{} is not null;
)-",
"CREATE OR REPLACE TABLE preprocessing_table AS SELECT {}, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the raw string used so SQL commands can be used as metadata name?

select {}
from preprocessing_table;
)-",
"create or replace view metadata_table as\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@Taepper Taepper merged commit 0c77123 into main Jan 29, 2024
4 of 6 checks passed
@Taepper Taepper deleted the data-error-very-long-sequences branch January 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants