Return the data version #188
Conversation
JonasKellerer
force-pushed
the
130-return-the-data-version
branch
2 times, most recently
from
a9161a3
to
71d453f
Compare
JonasKellerer
force-pushed
the
130-return-the-data-version
branch
from
71d453f
to
6856e83
Compare
|
Are we sure, that we do not want to set the data version during preprocessing? And then the build only reads the data version directly from the file. This would enable us to use the data version during change detection. And set a new data version if changes have been detected. This would also make it more flexible to already get the data version from the preprocessed input, in case we decide that SILO should not be the authority to mint new versions |
|
So far I have set the point where data version is mined at the end of the build process, which is also the end of the preprocessing step; just to have a first point and that it can be used in LAPIS #272. When looking at the preprocessing in #185 again we could also look at this again and find out a better spot? |
JonasKellerer
force-pushed
the
130-return-the-data-version
branch
from
6856e83
to
dd1aa81
Compare
Resolves #130
The data version is returned in the header as
Data-Versionand notLapis-Data-Versionas requested in the ticked, since it is the data version from silo.This should be reworked, with the verbose preprocessing.