-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return the data version #188
Conversation
a9161a3
to
71d453f
Compare
71d453f
to
6856e83
Compare
Are we sure, that we do not want to set the data version during preprocessing? And then the build only reads the data version directly from the file. This would enable us to use the data version during change detection. And set a new data version if changes have been detected. This would also make it more flexible to already get the data version from the preprocessed input, in case we decide that SILO should not be the authority to mint new versions |
So far I have set the point where data version is mined at the end of the build process, which is also the end of the preprocessing step; just to have a first point and that it can be used in LAPIS #272. When looking at the preprocessing in #185 again we could also look at this again and find out a better spot? |
6856e83
to
dd1aa81
Compare
Resolves #130
The data version is returned in the header as
Data-Version
and notLapis-Data-Version
as requested in the ticked, since it is the data version from silo.This should be reworked, with the verbose preprocessing.