More memory-efficient build process #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # endToEndTests/test/query.test.js # include/silo/storage/aa_store.h # include/silo/storage/sequence_store.h # src/silo/prepare_dataset.cpp # src/silo/storage/aa_store.cpp # src/silo/storage/database_partition.cpp # src/silo/storage/sequence_store.cpp
Taepper
force-pushed
the
flipBeforeInsert
branch
from
8914e43
to
b653753
Compare
|
Huh, here we have the tiny problem, that roaring on my local mac and roaring on linux differ in the internal memory usage (and some container types) |
…eaks in Threshold.cpp
|
I changed the numbers to reflect the results for ubuntu. Furthermore, I fixed the memory leaks in Threshold.cpp and thus we can resolve #123 |
Taepper
commented
Aug 3, 2023
endToEndTests/test/query.test.js
Outdated
Comment on lines
15
to
23
| let response = await server.post('/query').send(testCase.query); | ||
| try { | ||
| expect(response.status).to.equal(200); | ||
| expect(response.header['content-type']).to.equal('application/json'); | ||
| } catch (error) { | ||
| console.error('Error in response header! Error body:', response.body); | ||
| throw error; | ||
| } | ||
| expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); |
There was a problem hiding this comment.
Also, I hope you are okay with these changes, as this helps in debugging failing tests, where before the error message was not displayed, if a successful result was expected.
endToEndTests/test/query.test.js
Outdated
Comment on lines
15
to
23
| let response = await server.post('/query').send(testCase.query); | ||
| try { | ||
| expect(response.status).to.equal(200); | ||
| expect(response.header['content-type']).to.equal('application/json'); | ||
| } catch (error) { | ||
| console.error('Error in response header! Error body:', response.body); | ||
| throw error; | ||
| } | ||
| expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); |
There was a problem hiding this comment.
Doesn't this have the same effect?
Suggested change
| let response = await server.post('/query').send(testCase.query); | |
| try { | |
| expect(response.status).to.equal(200); | |
| expect(response.header['content-type']).to.equal('application/json'); | |
| } catch (error) { | |
| console.error('Error in response header! Error body:', response.body); | |
| throw error; | |
| } | |
| expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); | |
| let response = await server.post('/query').send(testCase.query); | |
| expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); | |
| expect(response.status).to.equal(200); | |
| expect(response.header['content-type']).to.equal('application/json'); |
There was a problem hiding this comment.
Ah, yes that looks better with a clearer control flow!
# Conflicts: # endToEndTests/test/info.test.js # endToEndTests/test/query.test.js
JonasKellerer
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now by default the symbol of the reference genome is flipped. And we insert the (flipped) data into already flipped bitmaps