-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More memory-efficient build process #183
Conversation
# Conflicts: # endToEndTests/test/query.test.js # include/silo/storage/aa_store.h # include/silo/storage/sequence_store.h # src/silo/prepare_dataset.cpp # src/silo/storage/aa_store.cpp # src/silo/storage/database_partition.cpp # src/silo/storage/sequence_store.cpp
8914e43
to
b653753
Compare
Huh, here we have the tiny problem, that roaring on my local mac and roaring on linux differ in the internal memory usage (and some container types) |
…eaks in Threshold.cpp
I changed the numbers to reflect the results for ubuntu. Furthermore, I fixed the memory leaks in Threshold.cpp and thus we can resolve #123 |
endToEndTests/test/query.test.js
Outdated
let response = await server.post('/query').send(testCase.query); | ||
try { | ||
expect(response.status).to.equal(200); | ||
expect(response.header['content-type']).to.equal('application/json'); | ||
} catch (error) { | ||
console.error('Error in response header! Error body:', response.body); | ||
throw error; | ||
} | ||
expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I hope you are okay with these changes, as this helps in debugging failing tests, where before the error message was not displayed, if a successful result was expected.
endToEndTests/test/query.test.js
Outdated
let response = await server.post('/query').send(testCase.query); | ||
try { | ||
expect(response.status).to.equal(200); | ||
expect(response.header['content-type']).to.equal('application/json'); | ||
} catch (error) { | ||
console.error('Error in response header! Error body:', response.body); | ||
throw error; | ||
} | ||
expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this have the same effect?
let response = await server.post('/query').send(testCase.query); | |
try { | |
expect(response.status).to.equal(200); | |
expect(response.header['content-type']).to.equal('application/json'); | |
} catch (error) { | |
console.error('Error in response header! Error body:', response.body); | |
throw error; | |
} | |
expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); | |
let response = await server.post('/query').send(testCase.query); | |
expect(response.body.queryResult).to.deep.equal(testCase.expectedQueryResult); | |
expect(response.status).to.equal(200); | |
expect(response.header['content-type']).to.equal('application/json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes that looks better with a clearer control flow!
# Conflicts: # endToEndTests/test/info.test.js # endToEndTests/test/query.test.js
Now by default the symbol of the reference genome is flipped. And we insert the (flipped) data into already flipped bitmaps