Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compiling And: append selection_child->predicates to predicates #180

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

fengelniederhammer
Copy link
Contributor

LAPIS tests are currently failing, since

{
  "action": {
    "type": "Aggregated"
  },
  "filterExpression": {
    "type": "And",
    "children": [
      {
        "type": "IntBetween",
        "column": "age",
        "from": 51,
        "to": 53
      }
    ]
  }
}

currently always returns Full. This should fix the issue.

Also I found it easier to follow if we have the possibility to trace compilation in the logs. It's quite cluttered, since it happens several times in parallel, but it's better than nothing. There is still room to improve.

Copy link
Collaborator

@Taepper Taepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

…- not vice versa

Also include more log statements to make compiling easier to debug.
@fengelniederhammer fengelniederhammer merged commit 4793394 into main Jul 26, 2023
5 checks passed
@fengelniederhammer fengelniederhammer deleted the fixAndExpression branch July 26, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants