-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with LimboAPI #316
Comments
I've provided a comment on the LimboAPI repository. Once Velocity merges this already-completed PR (based on extensive testing), LimboAPI will no longer be compatible with upstream Velocity. I'll leave this open for the time being. |
Velocity merging this might take months, while this will be broken @R00tB33rMan |
To follow up, I want to say that any upstream changes in Velocity lead to Limbo plugins being updated very quickly, such as here or here. This won't be an issue when upstream merges this, this is an issue regarding upstream backwards compatibility right now, even though packet registration is not an API. |
I'll look into reverting this change tomorrow (the 24th) despite its effectiveness. Hopefully, Velocity intends to merge this change sometime soon. |
Issue should be resolved in: b0794ca |
Thanks, this has been fixed for both my plugins and LimboAPI! |
Awesome! Thanks for the report! |
Expected Behavior
LimboAPI doesn't work on Velocity CTD.
Actual Behavior
LimboAPI should work on Velocity CTD.
Steps to Reproduce
Plugin List
LimboAPI
Velocity Version
3fe97fc
Additional Information
Elytrium/LimboAPI#163
The text was updated successfully, but these errors were encountered: