Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with LimboAPI #316

Closed
ghost opened this issue Sep 22, 2024 · 8 comments
Closed

Not compatible with LimboAPI #316

ghost opened this issue Sep 22, 2024 · 8 comments

Comments

@ghost
Copy link

ghost commented Sep 22, 2024

Expected Behavior

LimboAPI doesn't work on Velocity CTD.

Actual Behavior

LimboAPI should work on Velocity CTD.

Steps to Reproduce

  1. Install LimboAPI.
  2. It won't start.

Plugin List

LimboAPI

Velocity Version

3fe97fc

Additional Information

Elytrium/LimboAPI#163

@R00tB33rMan
Copy link

Expected Behavior

LimboAPI doesn't work on Velocity CTD.

Actual Behavior

LimboAPI should work on Velocity CTD.

Steps to Reproduce

1. Install LimboAPI.

2. It won't start.

Plugin List

LimboAPI

Velocity Version

3fe97fc

Additional Information

Elytrium/LimboAPI#163

I've provided a comment on the LimboAPI repository. Once Velocity merges this already-completed PR (based on extensive testing), LimboAPI will no longer be compatible with upstream Velocity. I'll leave this open for the time being.

@ghost
Copy link
Author

ghost commented Sep 22, 2024

Velocity merging this might take months, while this will be broken @R00tB33rMan

@ghost
Copy link
Author

ghost commented Sep 23, 2024

To follow up, I want to say that any upstream changes in Velocity lead to Limbo plugins being updated very quickly, such as here or here. This won't be an issue when upstream merges this, this is an issue regarding upstream backwards compatibility right now, even though packet registration is not an API.

@Justiks1337
Copy link

this broke my plugins, that depend on velocity, this very importart for my server smp and four black pigs. Author pls fix that
image

@R00tB33rMan
Copy link

I'll look into reverting this change tomorrow (the 24th) despite its effectiveness. Hopefully, Velocity intends to merge this change sometime soon.

@R00tB33rMan
Copy link

Expected Behavior

LimboAPI doesn't work on Velocity CTD.

Actual Behavior

LimboAPI should work on Velocity CTD.

Steps to Reproduce

1. Install LimboAPI.

2. It won't start.

Plugin List

LimboAPI

Velocity Version

3fe97fc

Additional Information

Elytrium/LimboAPI#163

Issue should be resolved in: b0794ca

@Justiks1337
Copy link

Thanks, this has been fixed for both my plugins and LimboAPI!

@R00tB33rMan
Copy link

Awesome! Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants