Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not working with Velocity CTD #163

Closed
ghost opened this issue Sep 22, 2024 · 2 comments
Closed

[BUG] Not working with Velocity CTD #163

ghost opened this issue Sep 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Sep 22, 2024

Velocity CTD changed packet registration system in GemstoneGG/Velocity-CTD@a93bdbb, so now LimboAPI won't start. I'm not sure whether this should be fixed on your end or on their end.

@ghost ghost added the bug Something isn't working label Sep 22, 2024
@hevav
Copy link
Member

hevav commented Sep 22, 2024

This fork changed too many things in the package registry code. And it is quite possible that this fork developer could change some internal stuff again. It will be impossible for us to support "independent forks" because they might change too many internal things.

I don't see any benefits of the changes in this commit. I think it's better for the fork developer to rollback these changes, so that the fork supports more plugins.

@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2024
@R00tB33rMan
Copy link

This fork changed too many things in the package registry code. And it is quite possible that this fork developer could change some internal stuff again. It will be impossible for us to support "independent forks" because they might change too many internal things.

I don't see any benefits of the changes in this commit. I think it's better for the fork developer to rollback these changes, so that the fork supports more plugins.

Breakage is in conjunction with this impending PR that has already and safely been merged. I'd suspect that you'd all need to make changes to LimboAPI once this PR is merged: PaperMC/Velocity#1314

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants