feat: connect submission storage to new landingzone production env #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marnixdessing
commented
Dec 28, 2023
marnixdessing
commented
- Subscribe to multiple SNS topics e.g. multiple webformulieren environments
- No conflicts will occur as the reference in the new production environment is bumped with a large gap (increased to 200.000 with a gap of 50.000 from the value in the old production environment that is increased from 10.000 to 150.000 over 2 years).
BramWithaar
reviewed
Dec 29, 2023
| Statics.acceptanceWebformulierenAccountId, | ||
| ], | ||
| subscribeToTopicArns: [ | ||
| 'arn:aws:sns:eu-west-1:315037222840:eform-submissions', |
There was a problem hiding this comment.
waarom staan hier hardcoded account id's?
There was a problem hiding this comment.
Ik heb hier de SNS topic ARNs toegevoegd omdat ik een lijst van ARNs wil opgeven. Door dit via SSM te doen moet je aan de haal met CloudFormation functions om de lijst op te splitsen (Fn.split() etc.). De plek waar deze ARNs gebruikt worden geeft vervolgens een foutmelding omdat deze een CloudFormation parameter referentie verwacht of een ARN string (niet een CloudFormation token).
BramWithaar
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.