feat: release #16
Merged
feat: release #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joostvanderborg
commented
Sep 8, 2023
•
joostvanderborg
commented
- docs
- fixes submissions without name
- allows resubmitting (for storing old submissions) from an SNS topic in this account (fixes Oude inzendingen duurzaam bewaren mijn-nijmegen#740)
Add better test for anonymous submissions.
Signed-off-by: github-actions <github-actions@github.com>
Adds an SNS topic, which can be subscribed to from a different account. It allows the accp webformulieren account to post to this topic. Submissions on this topic will be processed the same way other submissions are handled.
Allows the lambda role to publish to the encrypted SNS topic.
Allows the lambda role to publish to the encrypted SNS topic.
* fix: Allow KMS access for lambda role Allows the lambda role to publish to the encrypted SNS topic. * fix: remove kms references, topic Cross-account-cross-region KMS access with existing key not possible. * fix unused referenes * remove last unused reference
BramWithaar
reviewed
Oct 27, 2023
src/StorageStack.ts.orig
Outdated
| objectOwnership: ObjectOwnership.BUCKET_OWNER_ENFORCED, | ||
| lifecycleRules: [ | ||
| { | ||
| expiration: Duration.days(365), |
There was a problem hiding this comment.
waarom 365 dagen bewaren en niet korter of langer(zou ik verwachten nl)?
There was a problem hiding this comment.
Daar heeft nog niemand iets van gevonden, onbeperkt lijkt me ook onwenselijk. Ik zie overigens dat de merge conflict-file hierin zit, dus dit is niet nieuw.
BramWithaar
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.