-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replaces use-subscription with use-sync-external-store #5664
Merged
rayan1810
merged 4 commits into
GeekyAnts:patch
from
jono-allen:use-sync-external-store
Feb 27, 2023
Merged
refactor: replaces use-subscription with use-sync-external-store #5664
rayan1810
merged 4 commits into
GeekyAnts:patch
from
jono-allen:use-sync-external-store
Feb 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migrates to use-sync-external-store to support react 18 and nextjs
@jono-allen is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
5 tasks
@surajahmed is anyone available to review this? Also getting the same error. |
Also getting an error with react@18 and nextjs. @surajahmed could you please take a look at this? :) |
Let me check it and get it merged! |
rayan1810
requested review from
rayan1810
and removed request for
surajahmed
February 27, 2023 05:44
This was referenced May 21, 2024
This was referenced Jul 17, 2024
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrates to use-sync-external-store to support react 18 and nextjs
Summary
React 18.x and nextjs 13.x raises the error
Applying the same upgrade that nextjs applied to native-base fixes the error
https://github.com/vercel/next.js/pull/36733/files
Changelog
[refactor] [Changed] - Migrate to use-sync-external-store from use-subscription
Test Plan
Upgrading a project to react 18 and nextjs 13 resolves the error