Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BotListV3 improvements #197

Closed
wants to merge 6 commits into from
Closed

feat: BotListV3 improvements #197

wants to merge 6 commits into from

Conversation

lekhovitsky
Copy link
Collaborator

@lekhovitsky lekhovitsky commented Apr 10, 2024 •
edited
Loading

In this PR:

  • new IBotV3 interface that defines bot's required permissions which are checked in the bot list
  • BotListV3 interface changes:
    • new specialBots getter
    • redundant creditManager parameter removed from most functions that operate on creditAccount
    • EraseBot event removed in favor of SetBotPermissions(..., 0)
  • minor implementation improvements that make code more consistent
  • increase BotListV3 version to 3_10

@lekhovitsky
feat: BotListV3 improvements
ac89ec8 
* removes unnecessary `creditManager` argument from most functions
* bumps version to `3_10`
@lekhovitsky
feat: check bot's required permissions in bot list
21a6e06
@lekhovitsky lekhovitsky marked this pull request as ready for review April 11, 2024 13:20
@lekhovitsky
fix: uncomment to make the tests pass
2bb86f7
@lekhovitsky
fix: make bot list slightly more consistent
66275fc 
* prevent excessive events emission
* remove `EraseBot` event in favor of basic `SetBotPermissions`
* remove artifact comments about funding params
@lekhovitsky
docs: fix comment
91c1e11
@lekhovitsky lekhovitsky requested a review from 0xmikko April 17, 2024 09:46
@lekhovitsky lekhovitsky deleted the branch V3.1- April 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmikko 0xmikko Awaiting requested review from 0xmikko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lekhovitsky