fix: better readability

contracts/adapters/AbstractAdapter.sol

@@ -46,7 +46,7 @@ abstract contract AbstractAdapter is IAdapter, ACLTrait {
 
     /// @dev Ensures that external call credit account is set and returns its address
     function _creditAccount() internal view returns (address) {
-        return creditManager.externalCallCreditAccountOrRevert(); // U:[AA-2]
+        return creditManager.getExternalCallCreditAccountOrRevert(); // U:[AA-2]
     }
 
     /// @dev Ensures that token is registered as collateral in the credit manager and returns its mask

contracts/credit/CreditConfiguratorV3.sol

@@ -375,11 +375,11 @@ contract CreditConfigurator is ICreditConfigurator, ACLNonReentrantTrait {
         // If there is an existing adapter for the target contract, it has to be removed
         address currentAdapter = creditManager.contractToAdapter(targetContract);
         if (currentAdapter != address(0)) {
-            creditManager.setContractAllowance(currentAdapter, address(0)); // F: [CC-15A]
+            creditManager.setContractAllowance({adapter: currentAdapter, targetContract: address(0)}); // F: [CC-15A]
         }
 
         // Sets a link between adapter and targetContract in creditFacade and creditManager
-        creditManager.setContractAllowance(adapter, targetContract); // F:[CC-15]
+        creditManager.setContractAllowance({adapter: adapter, targetContract: targetContract}); // F:[CC-15]
 
         // adds contract to the list of allowed contracts
         allowedContractsSet.add(targetContract); // F:[CC-15]
@@ -406,8 +406,8 @@ contract CreditConfigurator is ICreditConfigurator, ACLNonReentrantTrait {
         // Sets both contractToAdapter[targetContract] and adapterToContract[adapter]
         // To address(0), which would make Credit Manager revert on attempts to
         // call the respective targetContract using the adapter
-        creditManager.setContractAllowance(adapter, address(0)); // F:[CC-17]
-        creditManager.setContractAllowance(address(0), targetContract); // F:[CC-17]
+        creditManager.setContractAllowance({adapter: adapter, targetContract: address(0)}); // F:[CC-17]
+        creditManager.setContractAllowance({adapter: address(0), targetContract: targetContract}); // F:[CC-17]
 
         // removes contract from the list of allowed contracts
         allowedContractsSet.remove(targetContract); // F:[CC-17]
@@ -432,7 +432,7 @@ contract CreditConfigurator is ICreditConfigurator, ACLNonReentrantTrait {
         }
 
         /// Removes the adapter => target contract link only
-        creditManager.setContractAllowance(adapter, address(0)); // F: [CC-40]
+        creditManager.setContractAllowance({adapter: adapter, targetContract: address(0)}); // F: [CC-40]
 
         emit ForbidAdapter(adapter); // F: [CC-40]
     }
@@ -751,7 +751,7 @@ contract CreditConfigurator is ICreditConfigurator, ACLNonReentrantTrait {
         external
         controllerOnly // F:[CC-2B]
     {
-        uint256 maxEnabledTokensCurrent = creditManager.maxAllowedEnabledTokenLength();
+        uint256 maxEnabledTokensCurrent = creditManager.maxEnabledTokens();
 
         // Checks that value is actually changed, to avoid redundant checks
         if (maxEnabledTokens != maxEnabledTokensCurrent) {

contracts/interfaces/ICreditManagerV3.sol

@@ -272,7 +272,7 @@ interface ICreditManagerV3 is ICreditManagerV3Events, IVersion {
     function liquidationThresholds(address token) external view returns (uint16);
 
     /// @dev The maximal number of enabled tokens on a single Credit Account
-    function maxAllowedEnabledTokenLength() external view returns (uint8);
+    function maxEnabledTokens() external view returns (uint8);
 
     /// @dev Returns the fee parameters of the Credit Manager
     /// @return feeInterest Percentage of interest taken by the protocol as profit
@@ -326,7 +326,7 @@ interface ICreditManagerV3 is ICreditManagerV3Events, IVersion {
 
     function setCreditAccountForExternalCall(address creditAccount) external;
 
-    function externalCallCreditAccountOrRevert() external view returns (address creditAccount);
+    function getExternalCallCreditAccountOrRevert() external view returns (address creditAccount);
 
     function getTokenByMask(uint256 tokenMask) external view returns (address token);
 

contracts/libraries/CreditLogic.sol

@@ -325,7 +325,7 @@ library CreditLogic {
         CollateralDebtData memory collateralDebtData,
         address creditAccount,
         uint256 quotedTokenMask,
-        uint256 maxAllowedEnabledTokenLength,
+        uint256 maxEnabledTokens,
         address underlying,
         function (uint256, bool) view returns (address, uint16) collateralTokensByMaskFn,
         bool countCollateral
@@ -336,7 +336,7 @@ library CreditLogic {
         uint256 underlyingPriceRAY =
             countCollateral ? convertToUSD(collateralDebtData._priceOracle, RAY, underlying) : 0;
 
-        collateralDebtData.quotedTokens = new address[](maxAllowedEnabledTokenLength);
+        collateralDebtData.quotedTokens = new address[](maxEnabledTokens);
 
         unchecked {
             for (uint256 tokenMask = 2; tokenMask <= quotedTokenMask; tokenMask <<= 1) {
@@ -363,7 +363,7 @@ library CreditLogic {
 
                     ++j;
 
-                    if (j >= maxAllowedEnabledTokenLength) {
+                    if (j >= maxEnabledTokens) {
                         revert TooManyEnabledTokensException();
                     }
                 }

contracts/pool/PoolQuotaKeeper.sol

@@ -101,7 +101,7 @@ contract PoolQuotaKeeper is IPoolQuotaKeeper, ACLNonReentrantTrait, ContractsReg
         creditManagerOnly // F:[PQK-4]
         returns (uint256 caQuotaInterestChange, bool enableToken, bool disableToken)
     {
-        int128 quotaRevenueChange;
+        int128 quotaRevenueChange; // TODO: better naming(?)
 
         AccountQuota storage accountQuota = accountQuotas[creditAccount][token];
         TokenQuotaParams storage tokenQuotaParams = totalQuotaParams[token];
@@ -149,7 +149,7 @@ contract PoolQuotaKeeper is IPoolQuotaKeeper, ACLNonReentrantTrait, ContractsReg
             }
         }
 
-        if (quotaRevenueChange > 0) {
+        if (quotaRevenueChange != 0) {
             IPool4626(pool).changeQuotaRevenue(quotaRevenueChange);
         }
     }

contracts/support/DataCompressor.sol

@@ -312,7 +312,7 @@ contract DataCompressor is IDataCompressor, ContractsRegisterTrait {
             result.degenNFT = creditFacade.degenNFT();
             result.isIncreaseDebtForbidden = creditFacade.maxDebtPerBlockMultiplier() == 0; // V2 only: true if increasing debt is forbidden
             result.forbiddenTokenMask = creditFacade.forbiddenTokenMask(); // V2 only: mask which forbids some particular tokens
-            result.maxEnabledTokensLength = creditManagerV2.maxAllowedEnabledTokenLength(); // V2 only: a limit on enabled tokens imposed for security
+            result.maxEnabledTokensLength = creditManagerV2.maxEnabledTokens(); // V2 only: a limit on enabled tokens imposed for security
             {
                 (
                     result.feeInterest,

contracts/test/integration/credit/CreditConfigurator.t.sol

@@ -1105,7 +1105,7 @@ contract CreditConfiguratorTest is Test, ICreditManagerV3Events, ICreditConfigur
         vm.prank(CONFIGURATOR);
         creditConfigurator.setMaxEnabledTokens(255);
 
-        assertEq(creditManager.maxAllowedEnabledTokenLength(), 255, "Credit manager max enabled tokens incorrect");
+        assertEq(creditManager.maxEnabledTokens(), 255, "Credit manager max enabled tokens incorrect");
     }
 
     /// @dev [CC-38]: addEmergencyLiquidator works correctly and emits event

contracts/test/integration/credit/CreditManager.t.sol

@@ -212,8 +212,8 @@ contract CreditManagerTest is Test, ICreditManagerV3Events, BalanceHelper {
     }
 
     function enableTokensMoreThanLimit(address creditAccount) internal {
-        uint256 maxAllowedEnabledTokenLength = creditManager.maxAllowedEnabledTokenLength();
-        _addAndEnableTokens(creditAccount, maxAllowedEnabledTokenLength, 2);
+        uint256 maxEnabledTokens = creditManager.maxEnabledTokens();
+        _addAndEnableTokens(creditAccount, maxEnabledTokens, 2);
     }
 
     function _openAccountAndTransferToCF() internal returns (address creditAccount) {
@@ -2011,7 +2011,7 @@ contract CreditManagerTest is Test, ICreditManagerV3Events, BalanceHelper {
         vm.prank(CONFIGURATOR);
         creditManager.setMaxEnabledTokens(255);
 
-        assertEq(creditManager.maxAllowedEnabledTokenLength(), 255, "Incorrect max enabled tokens");
+        assertEq(creditManager.maxEnabledTokens(), 255, "Incorrect max enabled tokens");
     }
 
     // /// @dev [CM-64]: closeCreditAccount reverts when attempting to liquidate while paused,

contracts/test/integration/credit/CreditManager_Quotas.t.sol

@@ -644,7 +644,7 @@ contract CreditManagerQuotasTest is Test, ICreditManagerV3Events, BalanceHelper
     // function test_CMQ_11_updateQuotas_reverts_on_too_many_tokens_enabled() public {
     //     (,,, address creditAccount) = cms.openCreditAccount();
 
-    //     uint256 maxTokens = creditManager.maxAllowedEnabledTokenLength();
+    //     uint256 maxTokens = creditManager.maxEnabledTokens();
 
     //     QuotaUpdate[] memory quotaUpdates = _addManyLimitedTokens(maxTokens + 1, 100);
 
@@ -675,7 +675,7 @@ contract CreditManagerQuotasTest is Test, ICreditManagerV3Events, BalanceHelper
         });
         enabledTokensMap |= tokensToEnable;
 
-        address[] memory quotedTokens = new address[](creditManager.maxAllowedEnabledTokenLength() + 1);
+        address[] memory quotedTokens = new address[](creditManager.maxEnabledTokens() + 1);
 
         quotedTokens[0] = tokenTestSuite.addressOf(Tokens.LINK);
         quotedTokens[1] = tokenTestSuite.addressOf(Tokens.USDT);

contracts/test/unit/adapters/AbstractAdapter.t.sol

@@ -50,7 +50,7 @@ contract AbstractAdapterUnitTest is TestHelper, CreditManagerMockEvents {
     function test_U_AA_02_creditAccount_works_correctly(address creditAccount) public {
         creditManager.setExternalCallCreditAccount(creditAccount);
 
-        vm.expectCall(address(creditManager), abi.encodeCall(creditManager.externalCallCreditAccountOrRevert, ()));
+        vm.expectCall(address(creditManager), abi.encodeCall(creditManager.getExternalCallCreditAccountOrRevert, ()));
         assertEq(abstractAdapter.creditAccount(), creditAccount, "Incorrect external call credit account");
     }
 

contracts/test/unit/adapters/CreditManagerMock.sol

@@ -13,7 +13,7 @@ contract CreditManagerMock is CreditManagerMockEvents {
     address public creditFacade;
     address public addressProvider;
 
-    address public externalCallCreditAccountOrRevert;
+    address public getExternalCallCreditAccountOrRevert;
     mapping(address => uint256) public getTokenMaskOrRevert;
 
     bytes _result;
@@ -34,7 +34,7 @@ contract CreditManagerMock is CreditManagerMockEvents {
     }
 
     function setExternalCallCreditAccount(address creditAccount) external {
-        externalCallCreditAccountOrRevert = creditAccount;
+        getExternalCallCreditAccountOrRevert = creditAccount;
     }
 
     function setMask(address token, uint256 mask) external {

contracts/test/unit/credit/CreditConfigurator.t.sol

@@ -1105,7 +1105,7 @@ contract CreditConfiguratorTest is Test, ICreditManagerV3Events, ICreditConfigur
         vm.prank(CONFIGURATOR);
         creditConfigurator.setMaxEnabledTokens(255);
 
-        assertEq(creditManager.maxAllowedEnabledTokenLength(), 255, "Credit manager max enabled tokens incorrect");
+        assertEq(creditManager.maxEnabledTokens(), 255, "Credit manager max enabled tokens incorrect");
     }
 
     /// @dev [CC-38]: addEmergencyLiquidator works correctly and emits event

contracts/test/unit/credit/CreditManager.t.old.sol

@@ -212,8 +212,8 @@ contract OldCreditManagerTest is Test, ICreditManagerV3Events, BalanceHelper {
     }
 
     function enableTokensMoreThanLimit(address creditAccount) internal {
-        uint256 maxAllowedEnabledTokenLength = creditManager.maxAllowedEnabledTokenLength();
-        _addAndEnableTokens(creditAccount, maxAllowedEnabledTokenLength, 2);
+        uint256 maxEnabledTokens = creditManager.maxEnabledTokens();
+        _addAndEnableTokens(creditAccount, maxEnabledTokens, 2);
     }
 
     function _openAccountAndTransferToCF() internal returns (address creditAccount) {
@@ -1958,7 +1958,7 @@ contract OldCreditManagerTest is Test, ICreditManagerV3Events, BalanceHelper {
         vm.prank(CONFIGURATOR);
         creditManager.setMaxEnabledTokens(255);
 
-        assertEq(creditManager.maxAllowedEnabledTokenLength(), 255, "Incorrect max enabled tokens");
+        assertEq(creditManager.maxEnabledTokens(), 255, "Incorrect max enabled tokens");
     }
 
     // /// @dev [CM-67]: checkEmergencyPausable returns pause state and enable emergencyLiquidation if needed

contracts/test/unit/credit/CreditManager_Quotas.t.sol

@@ -644,7 +644,7 @@ contract CreditManagerQuotasTest is Test, ICreditManagerV3Events, BalanceHelper
     // function test_CMQ_11_updateQuotas_reverts_on_too_many_tokens_enabled() public {
     //     (,,, address creditAccount) = cms.openCreditAccount();
 
-    //     uint256 maxTokens = creditManager.maxAllowedEnabledTokenLength();
+    //     uint256 maxTokens = creditManager.maxEnabledTokens();
 
     //     QuotaUpdate[] memory quotaUpdates = _addManyLimitedTokens(maxTokens + 1, 100);
 
@@ -675,7 +675,7 @@ contract CreditManagerQuotasTest is Test, ICreditManagerV3Events, BalanceHelper
         });
         enabledTokensMap |= tokensToEnable;
 
-        address[] memory quotedTokens = new address[](creditManager.maxAllowedEnabledTokenLength() + 1);
+        address[] memory quotedTokens = new address[](creditManager.maxEnabledTokens() + 1);
 
         quotedTokens[0] = tokenTestSuite.addressOf(Tokens.LINK);
         quotedTokens[1] = tokenTestSuite.addressOf(Tokens.USDT);