Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [BUG] #40 #53

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

PRIME-SV
Copy link
Contributor

@PRIME-SV PRIME-SV commented Oct 8, 2024

Describe your changes

  • Added a code chuck which check if all the stories are traversed and if so it triggers the onEnd emitter.

Screenshots - If Any (Optional)

Issue ticket number and link - If Any

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

Additional Information (Optional)

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ngx-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:41pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PRIME-SV, Thanks for contributing and Congrats on opening PR 🎉.

We will try to review as soon as possible and a maintainer will get back to you soon!

@Gauravdarkslayer
Copy link
Owner

Hi @PRIME-SV ,
Thanks for this valuable contribution, can you please make sure to complete the checklist ?

Thank you !!

@PRIME-SV
Copy link
Contributor Author

PRIME-SV commented Oct 9, 2024

Hi @Gauravdarkslayer,
Updated the checklist.

@Gauravdarkslayer Gauravdarkslayer merged commit d50b079 into Gauravdarkslayer:main Oct 9, 2024
5 checks passed
Copy link

github-actions bot commented Nov 9, 2024

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Story should stop after reaching it's end
2 participants