Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and migrate according to the docs #1

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

YoruNoHikage
Copy link

Changed a few obsolete stuff explained in the migration docs.
I'm updating my blog so I thought you might want these changes as well. Let's get them pushed back in the main repo. :)

@chmac
Copy link

chmac commented Oct 18, 2018

Just spotted this PR today. I've fixed my notification settings!

Thanks for contributing. I'm checking out your PR now and will merge shortly.

@chmac chmac merged commit b166f3d into GatsbyCentral:gatsby-v2 Oct 18, 2018
@YoruNoHikage
Copy link
Author

Awesome! :)

@chmac
Copy link

chmac commented Oct 18, 2018

There was a huge PR upstream which was submitted in May and merged in October. The result is that our v2 fork is no longer merge compatible with upstream. We're submitting this v2 version to the starters list directly.

@YoruNoHikage
Copy link
Author

Wow, no luck, didn't see that huge refactor...

@chmac
Copy link

chmac commented Oct 19, 2018

@YoruNoHikage Yeah, it was an unmerged PR for a long time, so even if we'd spotted it, would have been hard to know if it was going to be merged or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants