Test Case, Documentation, Refactoring for group_graph.py
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master back to test group graph branch
…per into test/group-graph
… but are under development
…per into test/group-graph
huangs1
requested review from
baldeosinghm and
enpuyou
and removed request for
aubreypc,
Michionlion,
ilikerustoo,
baldeosinghm and
enpuyou
This was referenced Mar 14, 2019
…per into test/group-graph
aubreypc
approved these changes
Mar 14, 2019
baldeosinghm
approved these changes
Mar 14, 2019
Michionlion
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request
Fixes #241
Fixes #263
Fixed #247
This PR provides the
group_graph.pytest cases, a refactoredgroup_graph.py, and documentation usinggroup_graph.pyin README.md.This PR contains the following:
if __name__ == "__main__":ingroup_graph.pytest_group_graph.pyto have 100% coverage ongroup_graph.py.def compatibilitywhen the input measure is invalid.group_graph.pyREADME.mdof how to use this feature and the theory behind itdef group_graph_partitionby using command in terminal window:objective_weights,objective_measures,preferences,preferences_weight,preferences_weight_match.--objective-weightsand--objective-measuresrequires the user to use the list as input which is hard to do in the terminal. However, we cannot use the CSV file due to Issue No Exception Handling for Reading a Single Line CSV #265 . One solution probably can be refactoring the code to make it read in objective-weights and objective-measures at the same time from the same CSV file.read_student_file.pywhich it was not able to read in float and string at the same time.pytest fixturewhich I used to generate CSV files so the test coverage forread_student_file.pycan still be 100% after the change.read_student_file.py,temp.append(record[0].replace('"', ""))seems unnessesary.Type of Change
Please describe the pull request as one of the following:
Tags
@Lancasterwu @thomad74 @wattob @baldeosinghm @yeej2