fixing imports in .py files in utils and tests
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torgrouper into quickfix/fixing-imports
ilikerustoo
requested review from
Michionlion,
paladp,
toccinAC,
yeej2 and
Lancasterwu
Michionlion
approved these changes
Feb 26, 2019
…ecognize this commit.
Lancasterwu
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Hi all, I was able to run all commands in the README.md after python3 gatorgrouper/utils/gatorgrouper.py --students-file "gatorgrouper/tests/students.csv". The pytest and linting tools are also working well. Besides I have a simple question of pylint configuration file, this is an excellent PR which fixed everything.
Lancasterwu
force-pushed
the
quickfix/fixing-imports
branch
from
e6fc6f8 to
4311d8d
Compare
This was referenced Feb 27, 2019
aubreypc
approved these changes
Feb 27, 2019
|
@Michionlion This is ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request
@ilikerustoo @paladp @yeej2 Fixed imports in the
.pymodules withinutilsandtestso thatGator Grouperactually works whilepylintandpytestdo not throw any errors.Fixes #179 :
Type of Change
Please describe the pull request as one of the following:
Refactored code,
pylint,pytestfixes.Tags
Please tag those who are responsible for reviewing proposed changes below.
@Lancasterwu @paladp @yeej2 @Michionlion @toccinAC