-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update WSDL resource files to latest Exchange2013_SP1 and add examples #266
Conversation
@Garethp we need you :-) ("This workflow requires approval from a maintainer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I've left two very minor suggestions that I think will make the examples a bit easier to read through. Once they're taken care of and the checks are green, I'm more than happy to merge this in!
examples/mail/archiveItems.php
Outdated
$request = [ | ||
'ArchiveSourceFolderId' => (new DistinguishedFolderIdType(DistinguishedFolderIdNameType::INBOX))->toArray(true), | ||
'ItemIds' => [ | ||
'ItemId' => array_map(function($itemId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a touch clearer if you just had an array of the two items, rather than passing them through array_map
. This will also clear up the code style error that's being thrown by phpcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, made that change.
|
||
$ews = ExchangeWebServices::withUsernameAndPassword('server', 'username', 'password'); | ||
|
||
$request = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add a quick explanation of what messages are being searched for, I think this example would flow more easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…at PHP SoapClient doesn't support
Pushed one more commit fixing the unit tests. It seems PHP SoapClient doesn't support the Exchange wsdl substitution groups, so I had to expand those like it used to be in the former types.xsd. |
@Garethp do the most recent updates seem OK to you? Maybe we can run the pipeline and see if tests are fine now - I've pushed a commit that fixes them. |
Sorry for the delay, you caught me just as I'd gone on Holiday. The tests are passing, I'll get this merged and released! Thank you for contribution! |
The cached wsdl resource files (services and messages/types schema) were fixed at 2010 SP2 version. According to this page: https://learn.microsoft.com/en-us/exchange/client-developer/exchange-web-services/ews-schema-versions-in-exchange latest version is 2013 SP1 which includes some operations like ArchiveItems.
This MR updates the cached schema files and adds a couple of more advanced examples: