Add drain, and link to WIP implementations. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +122,18 @@ pub fn resize(&mut self, new_len: uint, value: T) where T: Clone | |||
| This is actually easy to implement out-of-tree on top of the current Vec API, but it has | |||
| been frequently requested. | |||
|
|
|||
| * For HashMap and HashSet: | |||
There was a problem hiding this comment.
I don't see why Vec/RingBuf/BinaryHeap wouldn't also impl? (I mean everyone could but the node-based ones obviously don't extract that much value, other than only needing &mut, I guess).
There was a problem hiding this comment.
Heh. I forgot that RFCs were for more than just "stuff I've already written".
Will fix.
| ``` | ||
| /// Clears the map, returning all key-value pairs as an iterator. Keeps the | ||
| /// allocated memory for reuse. | ||
| pub fn drain(&mut self) -> DrainEntries<K, V>; |
There was a problem hiding this comment.
Close enough for horse grenades! Ship it!
Gankra
added a commit
that referenced
this pull request
Dec 17, 2014
Add drain, and link to WIP implementations.
Gankra
pushed a commit
that referenced
this pull request
Feb 11, 2015
Mention ChanReader/ChanWriter will be unstable
Gankra
pushed a commit
that referenced
this pull request
Aug 14, 2015
Modify read_full/read_exact RFC
Gankra
pushed a commit
that referenced
this pull request
Mar 29, 2017
Add specifics around feature gates
Gankra
pushed a commit
that referenced
this pull request
Mar 29, 2017
Explicit type punning alternative.
Gankra
pushed a commit
that referenced
this pull request
Aug 18, 2017
A lot of misc changes to extern types
Gankra
pushed a commit
that referenced
this pull request
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.