Sorting network visualizer rewrite #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove String.format usage
There appears to be a memory leak somewhere, but I can't find it.
Some sizing data is messed up, causing the browser to think the image is much bigger than it actually is.
There was a problem hiding this comment.
yep, I figured out how the svg algorithm works.
perhaps the "grouping" ("groups" are the sets of compswaps close to each other and vertically overlapping) part could be re-implemented for a performance boost (it's like O(n^2) for each group of size n) and to horizontally compact the groups. It reminds me of a familiar coding problem... but that'd be for after this PR lol
|
So are we all ready to merge then? |
|
Are we finally ready then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the sorting network visualizer from the ground up, in pure Java. This removes the dependency on Python, and makes visualization much faster (because Java is faster than Python).