Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change curl default timeout to 3 seconds #4592

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat: change curl default timeout to 3 seconds #4592

merged 1 commit into from
Jun 11, 2024

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Jun 11, 2024 •
edited
Loading

Description

changed default timeout of curl from 10 seconds to 3 seconds to prevent slowness.

Fixes #4462

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
feat: change curl default timeout to 3 seconds
db2b01d 
adjusted to 3 seconds from 10 for a timeout
@dgibbs64 dgibbs64 added this to the v24.3.0 milestone Jun 11, 2024
@dgibbs64 dgibbs64 linked an issue Jun 11, 2024 that may be closed by this pull request
[Bug]: Very Slow Script Executing #4462
Closed
@dgibbs64 dgibbs64 merged commit 685cca9 into develop Jun 11, 2024
5 checks passed
@dgibbs64 dgibbs64 deleted the feature/4524-timeout branch June 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v24.3.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Very Slow Script Executing
1 participant
@dgibbs64