Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pzserver): Add option to configure server memory usage #4204

Merged
merged 1 commit into from
May 16, 2023
Merged

feat(pzserver): Add option to configure server memory usage #4204

merged 1 commit into from
May 16, 2023

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented May 10, 2023

Description

Add option to configure project zomboïd server memory usage.
Avoid modifying server configuration files and allow using different settings per instances

I'm not found of configuring gigabytes with megabytes values and would like to refactore javaram to also take the unit (as in javaram="8G") and just do -Xmx${javaram} if that is ok with you I'll update the PR to also include that.
I've rapidly checked and javaram is only use to display java version in details if set. Nothing seems bound to a megabyte only usage (except perhaps old java versions ?)

Fixes #3056

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added this to the v23.3.0 milestone May 16, 2023
@dgibbs64 dgibbs64 merged commit 7fec810 into GameServerManagers:develop May 16, 2023
@KuSh KuSh deleted the pz-configure-java-ram branch May 18, 2023 16:44
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants