Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust) Support Rust query port needed after Feb 2nd! #4048

Merged
merged 6 commits into from
Feb 2, 2023

Conversation

un-boxing-man
Copy link
Contributor

@un-boxing-man un-boxing-man commented Dec 2, 2022

Description

Please include a summary of the change and which issues are fixed.
I am adding the "queryport" to the start Parameters and updated the "fn_info_game_rust" function to show the query port
as rust will be switching from RakNet to Steam Networking on January 5 2023.

Fixes #3801

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@un-boxing-man un-boxing-man changed the title add query port to rust [FEATURE] Support Rust queryport Dec 2, 2022
@un-boxing-man un-boxing-man changed the title [FEATURE] Support Rust queryport fix(rust) Support Rust query port Dec 2, 2022
@un-boxing-man
Copy link
Contributor Author

update was not released this month should be one of the upcoming months

@un-boxing-man
Copy link
Contributor Author

Rust servers will NEED query port for servers to remain in server browser after February 2nd update

@un-boxing-man un-boxing-man changed the title fix(rust) Support Rust query port fix(rust) Support Rust query port needed after Feb 2nd! Jan 28, 2023
@un-boxing-man
Copy link
Contributor Author

un-boxing-man commented Feb 2, 2023

Feb 2nd update has made it required
I have ben using this in production
image

@un-boxing-man un-boxing-man mentioned this pull request Feb 2, 2023
13 tasks
@naoestu
Copy link

naoestu commented Feb 2, 2023

When this update will be available?

@un-boxing-man
Copy link
Contributor Author

When this update will be available?

the rust update is out this pr just needs to be merged

@dgibbs64
Copy link
Member

dgibbs64 commented Feb 2, 2023

On it now :). Thanks

@dgibbs64 dgibbs64 self-requested a review February 2, 2023 21:39
@dgibbs64 dgibbs64 added this to the v22.3.0 milestone Feb 2, 2023
@dgibbs64 dgibbs64 changed the base branch from master to develop February 2, 2023 21:47
@un-boxing-man
Copy link
Contributor Author

Do you want me to resolve conflicts?

@dgibbs64
Copy link
Member

dgibbs64 commented Feb 2, 2023

yes please

@un-boxing-man
Copy link
Contributor Author

yes please

done : )

@dgibbs64 dgibbs64 merged commit 1fbb66d into GameServerManagers:develop Feb 2, 2023
@karenmcd
Copy link

karenmcd commented Feb 3, 2023

#4098 4098

is this because this hasn't been done yet? im sorry im kinda new at this github thing! wondering if I made a duplicate request.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Rust "queryport" variable
4 participants