Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query_gsquery): fix regression #3966

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Aug 24, 2022

Description

Fixes regresion from 81998f7

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added the type: bug Something isn't working label Aug 24, 2022
@h3o66
Copy link
Member Author

h3o66 commented Aug 24, 2022

fyi: @eggplants

@eggplants
Copy link
Contributor

Sorry, completely my fault.

@h3o66 h3o66 added this to the v22.2.0 milestone Aug 24, 2022
@h3o66
Copy link
Member Author

h3o66 commented Aug 24, 2022

Sorry, completely my fault.

Np, found it after rebasing #3904 and testing again with the dev command query raw.

@dgibbs64 dgibbs64 merged commit 28101a7 into GameServerManagers:develop Sep 22, 2022
@h3o66 h3o66 deleted the fix/regression-3913 branch September 22, 2022 19:57
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants