Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(vhserver): add escaped quotes to Valheim startparams to a… #3370

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Mar 14, 2021

…ccount for spaces (#3272)"

This reverts commit 8db3b6d.

Description

Reverting this commit as causing issues with password. I will investigate start parameters for Valheim further as getting odd behaviour in general.

Fixes #3367

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 changed the base branch from master to hotfix/v21.2.1 March 14, 2021 17:24
@dgibbs64 dgibbs64 added this to the v21.2.1 milestone Mar 14, 2021
@dgibbs64 dgibbs64 merged commit dd2ab39 into hotfix/v21.2.1 Mar 14, 2021
@dgibbs64 dgibbs64 deleted the feature/3367-vhserver branch March 14, 2021 17:24
@crumohr
Copy link

crumohr commented Mar 15, 2021

These single quotation marks lead to a very strange issue with the path of the config file and the place where worlds are saved. I had to remove the single quotation marks from the parameter -savedir, otherwise it wouldn't pickup the worlds saved under ~/.config/unity3d/IronGate/Valheim/worlds/.

@dgibbs64
Copy link
Member Author

@crumohr yeah I am seeing a bunch of issues with single and double quotes currently. I will be investigating it further to get my head around what exactly is causing the issues.

@h3o66 h3o66 linked an issue Mar 15, 2021 that may be closed by this pull request
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants