Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for config issues (ark & global) #1243

Merged
merged 15 commits into from
Jan 13, 2017
Merged

Conversation

UltimateByte
Copy link
Contributor

@UltimateByte UltimateByte commented Jan 13, 2017

ARK

GLOBAL
install_config.sh

  • Conditional check for existing cfg file before trying to alter it
  • Reworked order and comments
  • One liner for whatever; do to fit if syntax.

Screenshots
http://imgur.com/a/OFPtp

No config alteration for Ark, and requires to create the cfgdir. 
+ Rearranging presentation to make more visual sense
Otherwise you can think it's a servicename
Will test if ok
and default maxplayers is actually 70
@marvinlehmann
Copy link
Contributor

marvinlehmann commented Jan 13, 2017

I just noticed that we have a typo in the gamename: ARK: Surviv i al Evolved

@UltimateByte
Copy link
Contributor Author

Typo fiixed.
@dgibbs64 We need to remember informing people about important changes into the main arkserver script, especially the typo issue. Otherwise they're gonna get bad surprises after running ./arkserver uf

@dgibbs64
Copy link
Member

dgibbs64 commented Jan 13, 2017

Looks good. typo in branch name needs to be feature/ultimatebyte-131 not features/ultimatebyte-131 I will sort this out.

@dgibbs64 dgibbs64 merged commit c909a85 into develop Jan 13, 2017
@dgibbs64 dgibbs64 deleted the features/ultimatebyte-131 branch January 13, 2017 15:53
@UltimateByte UltimateByte changed the title Fix for config issues Fix for config issues (ark & global) Jan 15, 2017
@lock
Copy link

lock bot commented Jul 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants