Fixes #1235 (ark) #1236
Fixes #1235 (ark) #1236
Conversation
Admin password and servername are present into Ark but set within start parameters, so their edition by LGSM is pointless since they will be reset upon server shutdown into the config file, taking start parms values. Port values might need to be removed from default config file since they are ignored and start parameters are used instead,. On top of that, those are not changed upon server shutdown to match start parameters, so in the end, if they're not used, they can be misleading.
There was a problem hiding this comment.
I think that we should have to option to mkdir the missing save directory if not there. This will mean the download of the config will not be prevented.
Also I saw that servername and rconpassword (which should be adminpassword) are being set in two places. It shoudl be set in the config rather than the parms. Unless there is a specific reason why its set in parms.
Finally please can you amend your branches to be called feature/ultimatebyte-XXX for branches that are only for develop branch and hotfix/ultimatebyte-XXX for urgent fixes (should be rare). This allows me to easily manage "git flow"
|
OK, relevant remarks, I'll remind them and make another PR. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #1235
Ark had no config file out of the box because its directory didn't exist. Because of that, it wouldn't work out of the box.
Also, LGSM tried to alter config file even if it didn't exist. It's solved by an simple if -f check.
Working on this, I noticed another issue. Let's quote myself:
So I just removed fn_set_config_vars for Ark.
Ultimately, I have some concerns that need to be checked about Ark's default config file:
Port values might need to be removed from default config file since they are ignored and start parameters are used instead,. On top of that, those are not changed within the config file upon server shutdown to match start parameters, so in the end, if they're not used, they can be misleading. Somebody should test without them into the config file and see if it still works as intended. My guess is it does work perfectly.