Don't limit virtual column output types #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoscia
requested review from
a team and
danilagamma
and removed request for
a team
danilagamma
previously approved these changes
Oct 4, 2023
As of Druid 24.0.0, virtual columns are no longer restricted to LONG, FLOAT, DOUBLE and STRING. Also don't upcase the type name. For simple type names, Druid does that for us, and for complex type names, it's not necessarily appropriate.
legoscia
force-pushed
the
virtual-column-output-type
branch
from
5969fd9 to
17d27e7
Compare
aboroska
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Druid 24.0.0, virtual columns are no longer restricted to LONG, FLOAT, DOUBLE and STRING.
Also don't upcase the type name. For simple type names, Druid does that for us, and for complex type names, it's not necessarily appropriate.