Merge pull request #26 from GameAnalytics/arguments

Change argument order, add default value

README.md

@@ -25,9 +25,16 @@ q = from "my_datasource",
 And then send it:
 
 ```elixir
-ElixirDruid.post_query :default, q
+ElixirDruid.post_query q, :default
 ```
 
 `:default` is a configuration profile pointing to your Druid server.
 See `config/config.exs`, where you can change the profile or add new
 ones.
+
+The default value for the profile argument is `:default`, so if you
+only need a single configuration you can omit it:
+
+```elixir
+ElixirDruid.post_query q
+```

lib/elixir_druid.ex

@@ -9,19 +9,19 @@ defmodule ElixirDruid do
   Documentation for ElixirDruid.
   """
 
-  @spec post_query(atom, %ElixirDruid.Query{}) :: {:ok, term()} |
+  @spec post_query(%ElixirDruid.Query{}, atom()) :: {:ok, term()} |
   {:error, HTTPoison.Error.t() | Jason.DecodeError.t() | ElixirDruid.Error.t()}
-  def post_query(profile, query) do
+  def post_query(query, profile \\ :default) do
     url_path = "/druid/v2"
     body = ElixirDruid.Query.to_json query
     headers = [{"Content-Type", "application/json"}]
 
     request_and_decode(profile, :post, url_path, body, headers)
   end
 
-  @spec post_query!(atom, %ElixirDruid.Query{}) :: term()
-  def post_query!(profile, query) do
-    case post_query(profile, query) do
+  @spec post_query!(%ElixirDruid.Query{}, atom()) :: term()
+  def post_query!(query, profile \\ :default) do
+    case post_query(query, profile) do
       {:ok, response} -> response
       {:error, error} -> raise error
     end
@@ -47,7 +47,8 @@ defmodule ElixirDruid do
 
   defp request_and_decode(profile, method, url_path, body, headers) do
     broker_profiles = Application.get_env(:elixir_druid, :broker_profiles)
-    broker_profile = broker_profiles[profile]
+    broker_profile = broker_profiles[profile] ||
+      raise ArgumentError, "no broker profile with name #{profile}"
     url = broker_profile[:base_url] <> url_path
     options = http_options(url, broker_profile)