Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replaced testnet with signet #142

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

daviroo
Copy link
Contributor

@daviroo daviroo commented Nov 3, 2022

No description provided.

@daviroo daviroo requested review from samerbuna and openoms November 3, 2022 13:38
Copy link
Contributor

@openoms openoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reports testnet for signet as needed for bitcoinjs.

Indeed there is no difference between signet and testnet onchain addresses.

@daviroo daviroo merged commit d794aaf into main Nov 3, 2022
@ntheile
Copy link

ntheile commented Nov 4, 2022

@daviroo , @openoms

I am getting a parsing error in the mobile app for signet when trying to pay an invoice Please enter a valid destination I noticed this comment from bitcoinjs/bolt11 bitcoinjs/bolt11#58

According to the comment I think we need to "Use a custom Network during decode if the network is signet ( add the network object with tbs into the second arg for decode)".

I was able to hack it into the client in the file parsing-v2/index.ts here

I replaced this

payReq = bolt11.decode(lnProtocol)

with this https://github.com/bitcoinjs/bolt11/pull/58/files#diff-d717eb8408568e7a9e8b3add508df7571aafbed62ca52a1bd22fe224f18e5e17R37-R43

payReq = bolt11.decode(lnProtocol, {
    bech32: 'tbs',
    pubKeyHash: 0x6f,
    scriptHash: 0xc4,
    validWitnessVersions: [0, 1]
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants