feat: add support for H70C4 & H70C5
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support new Govee Christmas String Lights 2 H70C4（20m) & H70C5 (30m） See Galorhallen#62
To be able to run the `example/main.py` CLI
ramundomario
commented
Dec 5, 2024
Comment on lines
+215
to
+216
| "H70C4": create_with_capabilities(True, True, True, 10, True), | ||
| "H70C5": create_with_capabilities(True, True, True, 10, True), |
There was a problem hiding this comment.
🤔 Verified with the app that my lights H70C5 has ten segments.
Not sure for the H70C4 since I don't have it.
I don't know if we could take the info from somewhere, at least on the website seems not mentioned.
There was a problem hiding this comment.
Hi,
first of all, thanks for the PR
In this case I would leave the H70C4 with the segments control disabled (segments count to 0).
There was a problem hiding this comment.
👋
Done in 48089a7 🚀
There was a problem hiding this comment.
Hi,
I have H70C4 and I can control 10 segments through an app
There was a problem hiding this comment.
Nice @matiqos, thanks for the check!
@Galorhallen so previous commit dropped 😅
ramundomario
added a commit
to ramundomario/govee-local-api
that referenced
this pull request
Dec 6, 2024
Since we don't know exactly the segments of this strip See Galorhallen#80 (comment)
ramundomario
force-pushed
the
feature/support-H70C4-H70C5
branch
from
48089a7 to
9ba8cc4
Compare
Galorhallen
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support new Govee Christmas String Lights 2 H70C4 (20m) & H70C5 (30m）
Resolves #62
Second bonus commit to add
prompt_toolkitto dev dependencies to be able to run the CLI