Add support for using size polymorphic Cryptol functions in crux-mir-comp #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
RyanGlScott
reviewed
Oct 2, 2025
There was a problem hiding this comment.
This is looking nice! Some of the test cases are currently failing because their golden output needs to be updated, however.
Also, can you add some test cases demonstrating the new polymorphic functionality? Ideally, we'd have at least one test case that is expected to succeed, and perhaps some others that exercise the new error messages (which would be expected to fail).
RyanGlScott
reviewed
Oct 2, 2025
There was a problem hiding this comment.
Great, I'm happy with the way the code looks now (aside from two minor suggestions).
The algorithm that we use for mapping Cryptol types to Rust types has now become fairly complicated. Perhaps it's worth documenting this algorithm in crux-mir-comp's design document?
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
RyanGlScott
reviewed
Oct 3, 2025
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
RyanGlScott
approved these changes
Oct 3, 2025
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2657