MIR string slices #2025
Merged
MIR string slices #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
added
the
subsystem: crucible-mir
RyanGlScott
force-pushed
the
mir-string-slices
branch
from
702444f to
3a9b009
Compare
RyanGlScott
requested review from
sauclovian-g
and removed request for
eddywestbrook
sauclovian-g
approved these changes
Jul 1, 2024
kquick
approved these changes
Jul 1, 2024
This adds rudimentary support for constructing MIR `str` slice references via the new `mir_str_slice_value` and `mir_str_slice_range_value` SAWScript functions. These behave much like their cousins `mir_slice_value` and `mir_slice_range_value` (which work for array slices), except that they return something of type `&str` instead of, say, `&[u8]`. See the manual for the full details and current limitations of the approach. The `mir_str_slice_value`/`mir_str_slice_range_value` functions mostly share the same implementation as `mir_slice_value`/`mir_slice_range_value`, except for some minor differences regarding how the underlying types are handled. There is now a new `MirSliceInfo` data type that signals whether we are dealing with a `str` slice or an array slice. Fixes #1997.
RyanGlScott
force-pushed
the
mir-string-slices
branch
from
3a9b009 to
5b7a22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds rudimentary support for constructing MIR
strslice references via the newmir_str_slice_valueandmir_str_slice_range_valueSAWScript functions. These behave much like their cousinsmir_slice_valueandmir_slice_range_value(which work for array slices), except that they return something of type&strinstead of, say,&[u8]. See the manual for the full details and current limitations of the approach.The
mir_str_slice_value/mir_str_slice_range_valuefunctions mostly share the same implementation asmir_slice_value/mir_slice_range_value, except for some minor differences regarding how the underlying types are handled. There is now a newMirSliceInfodata type that signals whether we are dealing with astrslice or an array slice.Fixes #1997.