Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find SMT array write of a fixed size. #1762

Closed
wants to merge 5 commits into from

Conversation

andreistefanescu
Copy link
Contributor

No description provided.

@andreistefanescu andreistefanescu force-pushed the match-concrete-size-array branch 2 times, most recently from 877972c to 9770e7a Compare November 16, 2022 02:19
@andreistefanescu andreistefanescu force-pushed the match-concrete-size-array branch 2 times, most recently from ba9f385 to c5153b5 Compare February 22, 2023 14:52
@andreistefanescu andreistefanescu force-pushed the match-concrete-size-array branch 2 times, most recently from 2af12e7 to a31885d Compare April 3, 2023 23:57
@andreistefanescu andreistefanescu force-pushed the match-concrete-size-array branch 5 times, most recently from 4994b70 to 0aeaa71 Compare June 28, 2023 01:59
@andreistefanescu andreistefanescu force-pushed the match-concrete-size-array branch from bfeaa4b to 45be7c4 Compare July 17, 2023 23:44
@kquick
Copy link
Member

kquick commented Jan 24, 2024

This fixed an issue for Amazon, but it fails on the s2n test, presumably due to available resources (memory, although it should be re-run to verify this). Amazon keeps rebasing this on top of their stuff to keep things working. Should we switch to internal runners to provide more memory because this just slipped us over the threshold, or is this a significant regression that needs addressing?

@kquick
Copy link
Member

kquick commented Jan 24, 2024

This has a crucible dependency: GaloisInc/crucible#1074

@RyanGlScott
Copy link
Contributor

Another awslc CI timeout occurred in #2018, which has comparatively fewer changes. I wonder if the crucible submodule bump is the culprit?

@RyanGlScott
Copy link
Contributor

On second thought, I don't think the crucible submodule bump has anything to do with it. In fact, the CI now passes after rebasing these changes on top of a more recent commit. I suspect that the CI was timing out earlier because, historically speaking, the awslc proofs job was very close to the timeout limit, and this PR timed out by falling on the wrong side of the limit due to an unlucky fluke. But now that we've rebased this, we can see that the awslc job finishes within 27 minutes, which is the same amount of time that the jobs takes on master. (SMT query caching coming in clutch here.)

This still isn't quite ready to land yet, as the crucible changes that this PR relies on haven't yet landed. But it's very close.

@RyanGlScott
Copy link
Contributor

Superseded by #2037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants