Implement macaw-loader-riscv
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we favor HTTPS over SSH gitmodules in other repos, so I'm okay with this change. |
kquick
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Just a small recommendation for the CI to avoid cd calesthenics.
Also as discussed offline, switching submodules to https: could result in hitting unauthenticated rate limiting, especially if we use local runners. Not a current issue, but leaving this comment here in the hopes it will be helpful if we do have issues around this in the future.
RyanGlScott
force-pushed
the
T13-macaw-loader-riscv
branch
from
575e6da to
86ffb0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.