Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support toSignedInteger and deepseq in the reference evaluator #1784

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Support toSignedInteger and deepseq in the reference evaluator #1784

merged 2 commits into from
Jan 22, 2025

Conversation

RyanGlScott
Copy link
Contributor

Checks off two boxes in #1249.

@RyanGlScott RyanGlScott requested a review from yav December 20, 2024 17:10
@RyanGlScott RyanGlScott marked this pull request as ready for review December 20, 2024 17:10
@RyanGlScott RyanGlScott mentioned this pull request Jan 6, 2025
Open
yav
yav approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanGlScott RyanGlScott merged commit dbc0902 into master Jan 22, 2025
50 checks passed
@RyanGlScott RyanGlScott deleted the T1249-more-primitive-eval-ref-definitions branch January 22, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanGlScott @yav