Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sh_string should return '' for empty strings #887

Merged
merged 1 commit into from
Feb 11, 2017
Merged

sh_string should return '' for empty strings #887

merged 1 commit into from
Feb 11, 2017

Conversation

zachriggle
Copy link
Member

The current logic returns an empty string, which is technically correct (the best kind of correct), but in practice it's needed to pass empty strings on argv.

@zachriggle zachriggle added the bug label Feb 10, 2017
@zachriggle zachriggle added this to the Someday milestone Feb 10, 2017
@zachriggle zachriggle self-assigned this Feb 10, 2017
@zachriggle
Copy link
Member Author

Merging, only coverage failed

@zachriggle zachriggle merged commit 766c4d8 into dev Feb 11, 2017
@TethysSvensson TethysSvensson deleted the sh_string_empty branch February 12, 2017 23:14
TethysSvensson
TethysSvensson reviewed Feb 12, 2017
View reviewed changes
Copy link
Contributor

@TethysSvensson TethysSvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TethysSvensson TethysSvensson modified the milestones: 3.5.0, Someday Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TethysSvensson TethysSvensson TethysSvensson left review comments

Assignees

@zachriggle zachriggle

Labels
bug
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zachriggle @TethysSvensson